Skip to content

fix #22571 (OpenAPINormalizer): Removed reset of OAS content #22573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JPPortier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #22571 (OpenAPINormalizer): Removed reset of OAS content #22573

JPPortier wants to merge 1 commit into from
+0 −4

Conversation

@JPPortier
Copy link
Contributor

@JPPortier JPPortier commented Dec 22, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)

@JPPortier JPPortier mentioned this pull request Dec 22, 2025
Open
6 tasks
@JPPortier
Copy link
Contributor Author

JPPortier commented Dec 22, 2025

For reference, related to:

Not having enough insight about the right path to fix how specification are lost during the normalization

@wing328 wing328 closed this Jan 6, 2026
@wing328 wing328 reopened this Jan 6, 2026
@wing328
Copy link
Member

wing328 commented Jan 13, 2026 

    type: string
    format: null
    $ref: null
    description: null
    title: purple
    multipleOf: null
    maximum: null
    exclusiveMaximum: null
    minimum: null
    exclusiveMinimum: null
    maxLength: null
    minLength: null
    pattern: null
    maxItems: null
    minItems: null
    uniqueItems: null
    maxProperties: null
    minProperties: null
    required: null
    not: null
    properties: null
    additionalProperties: null
    nullable: null
    readOnly: null
    writeOnly: null
    example: null
    externalDocs: null
    deprecated: null
    discriminator: null
    xml: null
}]]
[INFO]
[INFO]
[ERROR] Tests run: 3612, Failures: 2, Errors: 0, Skipped: 4
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for openapi-generator-project 7.19.0-SNAPSHOT:
[INFO]
[INFO] openapi-generator-project .......................... SUCCESS [  3.079 s]
[INFO] openapi-generator-core ............................. SUCCESS [  6.827 s]
[INFO] openapi-generator (core library) ................... FAILURE [02:37 min]
[INFO] openapi-generator (executable) ..................... SKIPPED
[INFO] openapi-generator (maven-plugin) ................... SKIPPED
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... SKIPPED
[INFO] openapi-generator-online ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:50 min
[INFO] Finished at: 2026-01-13T14:02:19+08:00
[INFO] ------------------------------------------------------------------------
[INFO] 27 goals, 27 executed
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.2.5:test (default-test) on project openapi-generator: There are test failures.
[ERROR]
[ERROR] Please refer to C:\Users\User\code\openapi-generator2\modules\openapi-generator\target\surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

build failed

can you please take a look when you've time?

@JPPortier
Copy link
Contributor Author

JPPortier commented Jan 13, 2026

can you please take a look when you've time?

Hi William thank your for feedback,

I could but purpose of this PR was to be able to have feedback about what could be the proper way to fix this: If just removing the "reset" if good enough no problem and I should be able to update tests.

Not sure to have myself enough knowledge of tool but another idea could have been to still transform list of const as enum because if will enable to have them used from mustache templates for any languages, but may be adding some "x-enum-deprecated" (like there is x-enum-descriptions: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java#L1487)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JPPortier @wing328